Repository navigation
Stop the smoke test hanging on Roslyn's daemon - #19
Merged
Merged
Conversation
Roslyn runs as a daemon that stays alive 15 minutes after its last client and inherits Neovim's output handles. With Roslyn installed, a smoke run whose output is redirected (as in CI) finished but didn't return until the daemon exited. Set its keepalive to 0 for smoke runs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 90315f97-7c82-4bc1-9bf1-2f8460782554
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roslyn (#17) runs as a daemon that stays alive 15 minutes after its last client and inherits Neovim's output handles. On a machine with Roslyn installed, a smoke run with redirected output (like CI's) printed
smoke: OKand then didn't return until the daemon exited; it happened on the live config after #17/#18. CI hasn't hit it yet only because Roslyn is still installing when the C# buffer opens.nnSetsROSLYN_LANGUAGE_SERVER_DAEMON_KEEPALIVE=0for smoke runs. Tested with the real install (Roslyn present): the redirected run returned after 10s with no daemon left; before, it hung until I killed the daemon.